On 09/19/2012 03:59 PM, Ian Price wrote:
Mark H Weaver<m...@netris.org> writes:
Your fixes look good to me. It would be good to add tests for the
listen option also.
(system repl server) does need tests, no question. But, I'm not sure how
I would test the command-line stuff. I suppose we could run a guile
instance with various arguments, have it output relevant variables, and
check the output. Hmm. This seems like it would be problematic with
--listen though, since we'd need to run two instances, and make some
visible changes to the instance. Maybe I just haven't thought it through
enough.
I agree that it's not trivial to implement these tests. We shouldn't
let this get in the way of committing your fix, which is clearly
important. Since there have been no objections, I think you should go
ahead and commit it to the stable-2.0 branch.
Mark
