01/10: Avoid crashing when no compare arguments are provided

[Christopher Baines]

cbaines pushed a commit to branch master
in repository data-service.

commit c751031a263a2adc00149c5c8a05446bbdfc2c12
Author: Christopher Baines <m...@cbaines.net>
AuthorDate: Sat Nov 21 16:49:58 2020 +0000

    Avoid crashing when no compare arguments are provided
---
 guix-data-service/web/compare/controller.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/guix-data-service/web/compare/controller.scm 
b/guix-data-service/web/compare/controller.scm
index df7e89a..5edd922 100644
--- a/guix-data-service/web/compare/controller.scm
+++ b/guix-data-service/web/compare/controller.scm
@@ -182,14 +182,16 @@
                    (($ <invalid-query-parameter> value)
                     (with-thread-postgresql-connection
                      (lambda (conn)
-                       (select-job-for-commit conn value))))
+                       (and (string? value)
+                            (select-job-for-commit conn value)))))
                    (_ #f)))
                 (target-job
                  (match (assq-ref query-parameters 'target_commit)
                    (($ <invalid-query-parameter> value)
                     (with-thread-postgresql-connection
                      (lambda (conn)
-                       (select-job-for-commit conn value))))
+                       (and (string? value)
+                            (select-job-for-commit conn value)))))
                    (_ #f))))
         (case (most-appropriate-mime-type
                '(application/json text/html)