Nikita Karetnikov <nik...@karetnikov.org> skribis: >>> I think we should change ‘--list-generations’ to not output the zeroth >>> generation. Even though it could be present in the profile, users >>> shouldn’t be concerned about it. > >> Agreed. > > Can I push these patches to ‘master’? Should I document that the zeroth > generation is always ignored?
Why not. There’s already a mention of “profile zero” (which should be changed to “generation zero”) under ‘--roll-back’ in the manual. > From 7fc042876bf00031d6b36b8d697984ce1ee1700e Mon Sep 17 00:00:00 2001 > From: Nikita Karetnikov <nik...@karetnikov.org> > Date: Mon, 23 Sep 2013 22:56:21 +0000 > Subject: [PATCH 1/3] tests: Test that '--list-generations' may not output > anything. Make sure to add a commit log. > --- > tests/guix-package.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/guix-package.sh b/tests/guix-package.sh > index b09a9c0..e2c0374 100644 > --- a/tests/guix-package.sh > +++ b/tests/guix-package.sh > @@ -85,6 +85,9 @@ then > test "`guix package -p "$profile" -l | cut -f1 | grep guile | head -n1`" > \ > = " guile-bootstrap" > > + # Do not output anything when a generation does not exist. > + test -z "`guix package -p "$profile" -l 42`" I’d rather test the exit code instead of/in addition to the output. Does it exit with 1? I think it should. > + (or (zero? number) > + (begin > + (format #t (_ "Generation ~a\t~a~%") number OK, but rather use (unless (zero? number) (format #t ...) ...) > From 64b01b6414d42b9b495059223e5312d9d01ba860 Mon Sep 17 00:00:00 2001 > From: Nikita Karetnikov <nik...@karetnikov.org> > Date: Tue, 24 Sep 2013 00:36:51 +0000 > Subject: [PATCH 3/3] tests: Use 'test -z' to check that a string equals zero. > > --- > tests/guix-package.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK. Thanks, Ludo’.