ggr...@riseup.net skribis: > Hoping to gradually get back into packaging some stuff of interest. Here's > libglade for now, if anything looks wrong be sure to let me know. :^)
OK, so here’s a proper review, on the assumption that it’s needed. > From 58b053edfabd89b5c9da034b295791ceb1cf1281 Mon Sep 17 00:00:00 2001 > From: Guy Grant <ggr...@riseup.net> > Date: Thu, 27 Feb 2014 17:46:06 -0600 > Subject: [PATCH] gnu: Add libglade Please add a proper commit log. > +(define-public libglade > + (package > + (name "libglade") > + (version "2.6.4") > + (source (origin > + (method url-fetch) > + (uri (string-append > + > "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-" > + version > + ".tar.gz")) Use mirror://gnome. > + (synopsis "Allows you to load glade interface files in a program at > runtime") Rather something like “Load GTK+2 Glade interface files at run time”, WDYT? > + (description > + "Libglade is a library that provides interfaces for loading graphical > interfaces > +described in glade xml files and for accessing the widgets built in the > loading process, > +.glade files are generated by the Glade application.") > + (license license:lgpl2.0))) I guess it’s v2.0-or-any-later-version, no? (Or even 2.1.) Could you check that? If that is the case, then use license:lgpl2.0+. Could you send an updated patch? Thanks! Ludo’.