Andreas Enge <andr...@enge.fr> skribis: > On Sat, May 24, 2014 at 12:40:31AM -0500, Eric Bavier wrote: >> + (native-inputs `(("file" ,file))) >> + (arguments >> + `(#:phases (alist-cons-before >> + 'configure 'patch-configure >> + (lambda _ >> + (substitute* "configure" >> + (("/usr/bin/file") >> + (which "file")))) >> + %standard-phases))) > > Is this really needed? Lots of packages using the autotools look for "file", > and when it is not available, nothing bad seems to happen. I was told before > to just not bother.
Agreed. Nikita Karetnikov <nik...@karetnikov.org> skribis: >> This patch adds Mcrypt, and two library dependencies. Comments >> welcome. > > I believe the libraries should be listed in the commit message as new > variables. Ludo, WDYT? Agreed, in the subject line. Ludo’.