宋文武 <iyzs...@gmail.com> skribis: > Ludovic Courtès <l...@gnu.org> writes: > >> 宋文武 <iyzs...@gmail.com> skribis: >> >>> Fixes a regression introduced in 666aa99. >>> Reported by Felipe López and David Thompson. >>> >>> * gnu/packages/sdl.scm (sdl)[inputs]: Add glu. >>> [arguments]<#:configure-flags>: Replace '--disable-sdl-dlopen' with >>> '--disable-alsa-shared --disable-pulseaudio-shared --disable-x11-shared'. >> >> [...] >> >>> --- a/gnu/packages/sdl.scm >>> +++ b/gnu/packages/sdl.scm >>> @@ -60,8 +60,11 @@ >>> (build-system gnu-build-system) >>> (arguments >>> '(;; Explicitly link against shared libraries instead of dlopening >>> them. >>> - ;; For X11, ALSA, PulseAudio, etc. >>> - #:configure-flags '("--disable-sdl-dlopen") >>> + ;; For X11, ALSA, and PulseAudio. >>> + ;; OpenGL library is still dlopened at runtime. >>> + #:configure-flags '("--disable-alsa-shared" >>> + "--disable-pulseaudio-shared" >>> + "--disable-x11-shared") >> >> So without these flags libpulse.so, libalsa.so, etc. are dlopened? >> (“disable shared” is a bit misleading in the flag names.) > Yes.
OK. Could you change the comment to: Don’t dlopen X11, ALSA, and PulseAudio. >>> (native-inputs `(("pkg-config" ,pkg-config))) >>> (inputs `(("libxrandr" ,libxrandr) >>> ("mesa" ,mesa) >>> + ("glu" ,glu) >> >> Because of --disable-x11-shared, glu must be found at configure time, >> right? > No, without glu, SDL's configure reported with: > checking for OpenGL (GLX) support... no OK. OK to push with this tiny change, and sorry for the delay! Thanks, Ludo’.