Mark H Weaver <m...@netris.org> skribis:

> l...@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <m...@netris.org> skribis:

[...]

> I would suggest using (geteuid) instead.  Also, we should set the mode.
> In this particular case, if we had changed the owner without also
> changing the mode, rekado's system still would have been quite broken.

Good points.  I have taken these into accounts and committed as 4a35a86.

>> I wonder if the activation code shouldn’t systematically do
>> (chown "/" 0 0) as well.
>>
>> Thoughts?
>
> I'm not sure.  Trying to fix individual things during activation that
> might have been broken is a slippery slope.  We cannot hope to fix
> everything that might have been broken using this approach, and on the
> other hand we might undo some change that the user made intentionally.

Yeah, makes sense to me.

Thanks!

Ludo’.

Reply via email to