Ludovic Courtès (2015-11-14 18:03 +0300) wrote: > Alex Kost <alez...@gmail.com> skribis: > >> Ludovic Courtès (2015-11-03 16:27 +0300) wrote: > > [...] > >>>> + ;; Avoid non-determinism related to generated timestamps. >>>> + (setenv "SOURCE_DATE_EPOCH" "1") >>>> + >>>> ;; The trick is to #:allow-other-keys everywhere, so that each >>>> procedure in >>>> ;; PHASES can pick the keyword arguments it's interested in. >>>> (every (match-lambda >>> >>> Yes, as simple as this. >> >> Great, thanks! I see that you used (setenv "SOURCE_DATE_EPOCH" "0") in >> 'tk-update' commit, so I also changed the value to "0". > > Oh, good point. I don’t know if it matters much (for Python it seems to > make no difference), but I think “1” is the safest choice because the > mtime on files in the store is set to 1, not 0. I’ll fix that in > ‘tk-update’.
I see, thanks for explaining. >>>>> Could you also submit it upstream, Cc’ing guix-devel and >>>>> reproducible-bui...@lists.alioth.debian.org? Hopefully that is >>>>> acceptable. (I searched a bit but didn’t find a similar patch by the >>>>> Debian Reproducible team, but patch-tracker.debian.org is unreachable.) >>>> >>>> I'm afraid it's a too hard task for me, sorry. I wouldn't like to mail >>>> to so many places. >>> >>> Or email only emacs-devel if you prefer. >>> >>> An experienced Emacs hacker like you shouldn’t have to be afraid of that. >> >> After fighting with myself for all these days, I must admit I'm not >> brave enough for this task yet, sorry. > > You’re not the one to be sorry. It tells more about the weaknesses of > the Emacs developer community than about yours. Oh, no, no; it's totally me. I have problems with communicating with people. > I’ll post it if you don’t mind. Yes, please, it would be a great relief for me, thank you! >> From a99fb41a7b84dd28c1a5b3f53cf14ca3c43785e7 Mon Sep 17 00:00:00 2001 >> From: Alex Kost <alez...@gmail.com> >> Date: Sat, 14 Nov 2015 14:04:43 +0300 >> Subject: [PATCH 1/2] build-system/gnu: Set 'SOURCE_DATE_EPOCH'. >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit >> >> Suggested by Ludovic Courtès <l...@gnu.org>. >> >> * guix/build/gnu-build-system.scm (gnu-build): Set SOURCE_DATE_EPOCH for >> deterministic builds. > > [...] > >> + ;; Avoid non-determinism related to generated timestamps. >> + (setenv "SOURCE_DATE_EPOCH" "0") > > OK with that set to 1. Fixed and pushed, thanks. -- Alex