ren...@openmailbox.org writes: > hi, > > can you help me to review this patch, gtk-vnc is a API for Vinagre > program. Welcome! > > Regards. > > From cfeac9d0ca6505f98ba206aa4dae5170431baf8e Mon Sep 17 00:00:00 2001 > From: Rene Saavedra <ren...@openmailbox.org> > Date: Tue, 26 Jan 2016 21:47:36 +0100 > Subject: [PATCH] gnu: Add gtk-vnc. Missing commit message, it should look like:
* gnu/packages/gtk-vnc.scm: New file. * gnu-system (GNU_SYSTEM_MODULES): Add it. But I'd like to put it (and vinagre) in gnome.scm. > > --- > gnu-system.am | 1 + > gnu/packages/gtk-vnc.scm | 50 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 51 insertions(+) > create mode 100644 gnu/packages/gtk-vnc.scm > > diff --git a/gnu-system.am b/gnu-system.am > index 3426056..18be503 100644 > --- a/gnu-system.am > +++ b/gnu-system.am > @@ -355,6 +355,7 @@ GNU_SYSTEM_MODULES = \ > gnu/packages/zile.scm \ > gnu/packages/zip.scm \ > gnu/packages/zsh.scm \ > + gnu/packages/gtk-vnc.scm \ > \ > gnu/services.scm \ > gnu/services/avahi.scm \ > diff --git a/gnu/packages/gtk-vnc.scm b/gnu/packages/gtk-vnc.scm > new file mode 100644 > index 0000000..a7b8cf8 > --- /dev/null > +++ b/gnu/packages/gtk-vnc.scm > @@ -0,0 +1,50 @@ > +(define-module (gnu packages gtk-vnc) > + #:use-module ((guix licenses) #:prefix license:) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu) > + #:use-module (gnu packages glib) > + #:use-module (gnu packages gnome) > + #:use-module (gnu packages gtk) > + #:use-module (gnu packages pkg-config) > + #:use-module (gnu packages tls) > + #:use-module (gnu packages gnupg) > + #:use-module (gnu packages pulseaudio)) > + > +(define-public gtk-vnc > + (package > + (name "gtk-vnc") > + (version "0.5.4") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "1rwwdh7lb16xdmy76ca6mpqfc3zfl3a4bkcr0qb6hs6ffrxak2j8")))) > + (build-system gnu-build-system) > + (arguments > + `(#:configure-flags > + (list "--with-gtk=3.0" "--enable-vala" "--without-sasl"))) > + (inputs > + `(("gtk+" ,gtk+) > + ("vala" ,vala) > + ("gjs" ,gjs) > + ("libgcrypt" ,libgcrypt) > + ("gnutls" ,gnutls) > + ("glib" ,glib "bin") > + ("pulseaudio" ,pulseaudio))) > + (native-inputs > + `(("pkg-config" ,pkg-config) > + ("intltool" ,intltool))) I think glib:bin and vala belong to native-inputs, usually they are only used during build. > + (home-page "https://wiki.gnome.org/Projects/gtk-vnc") > + (synopsis > + "VNC viewer widget for GTK.") Put synopsis into one line, use `GTK+' and remove the `.'. > + (description > + "GTK-VNC is an API used by Vinagre client application, Boxes and > +virt-viewer. GTK-VNC supports authentication extensions as SASL, TLS, > VeNCrypt. > +Additionally supports encoding extensions.") > + (license license:lgpl2.1))) Most source files say LGPL-2.0+, while the COPYING.LIB is LGPL-2.1. I think the license should be `lgpl2.1+'.