iyzs...@member.fsf.org (宋文武) skribis: > Andreas Enge <andr...@enge.fr> writes: > >> Hello, >> >> when installing xfce, there is a collision with xfce4-session for the file >> startxfce4. >> >> The reason is the following: >> (alist-replace >> 'install >> (lambda* (#:key outputs #:allow-other-keys) >> (let* ((out (assoc-ref outputs "out")) >> (bin (string-append out "/bin")) >> (prog (string-append bin "/startxfce4"))) >> (mkdir-p bin) >> (symlink (string-append >> (assoc-ref %build-inputs "xfce4-session") >> "/bin/startxfce4") >> prog) >> (wrap-program prog >> ;; For xfce4-panel plugins. >> `("X_XFCE4_LIB_DIRS" = ,(list (getenv "X_XFCE4_LIB_DIRS")))))) >> (propagated-inputs >> ... >> ("xfce4-session" ,xfce4-session) >> >> So if I understand correctly, the startxfce4 of xfce will end up being a >> wrapped version of the one in xfce4-session. However, if both are installed, >> could it not be possible that the non-wrapped version ends up in the profile? > When only the ‘xfce’ package is installed, the wrapped version is used. > I don’t know what will happen when both ‘xfce’ and ‘xfce4-session’ are > installed to a profile. > > This package was introduced before the ‘etc/profile’ where enviroment > variables from search-paths are set. So, the wrapper is redundant now.
The wrapper would still be useful when it’s not installed in a profile (for instance, when running $(guix build xfce4)/bin/startxfce4), but that’s probably not a use case worth supporting in this case. Thoughts? > From 6f6ba4e8c347770b279e9344ba49bf305cd41da8 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzs...@gmail.com> > Date: Mon, 29 Feb 2016 14:57:56 +0800 > Subject: [PATCH] gnu: xfce: Don't wrap 'startxfce4'. > > The necessary environment variables are set by 'etc/profile' now. > > * gnu/packages/xfce.scm (xfce)[build-system]: Use 'trivial-build-system'. > [arguments]: Simplify. Otherwise the patch LGTM. Thanks, Ludo’.