On Sun, Apr 03, 2016 at 08:29:22PM +0200, Tobias Geerinckx-Rice wrote: > Hullo Leo, > > Thanks, as always, for the review! > > On 03/04/16 02:53, Leo Famulari wrote: > > On Sat, Apr 02, 2016 at 03:29:33PM +0200, Tobias Geerinckx-Rice wrote: > >> + (add-after > >> + 'install 'move-static-libraries > > > > How about calling the phase 'install-static' as in your btrfs-progs > > patch? > > The two phases do subtly (?) different things. INSTALL-STATIC calls an > additional ‘make install-static’ target that wouldn't be run otherwise. > MOVE-STATIC-LIBRARIES moves some static files already installed to OUT > by the default 'install phase to a different output, STATIC. > > I don't think drawing explicit parallels between the two (by choosing > identical names) makes anything any clearer, but have no strong feelings > either way.
Okay, that makes sense. > > Kind regards, > > T G-R >