On Wed, Apr 13, 2016 at 12:05 PM, Eric Bavier
<[email protected]> wrote:
> On 2016-04-13 09:45, Thompson, David wrote:
>>
>> * gnu/packages/engineering.scm (geda-gaf)[inputs]: Add m4 and pcb.
>> [arguments]: Add configure flags that point to PCB data files.
>
>
> Nitpick: '[' should align with "gnu".

The GNU ChangeLog standards say not to do this.  We used to indent for
awhile, but have since stopped.

> Is m4 really required at runtime?

Yes, it is.  Transforming a schematic to a PCB, for example, requires
processing M4 macros.

Thanks for the review! I'm going to push this.

- Dave

Reply via email to