On Thu, Jul 21, 2016 at 2:24 PM, Ludovic Courtès <l...@gnu.org> wrote: > David Craven <da...@craven.ch> skribis: > >>> I think packages with a “bin” output are not always used as native >>> inputs, so I would drop this rule. >> >> From searching the code-base we have I couldn't find a counter example. Do >> you think it's ok to check for glib:bin specifically? > > Yes, sounds good to me. > > However, make sure to match on the package name + output, not on the > label. That is, ‘lint’ should correctly diagnose something like: > > (inputs `(("somethingsilly" ,glib "bin")))
Yes, this is very important, as you have newbies coming now that try to package software for guix and they don't understand what they are doing. :-) I was wondering the other day, what this "somethingsilly" string is for, is it just a string or does it need to be a reference to something not silly... Looks like it's just a string, but... I volunteer for reviewing error message, to see if they pass the low-level schemer test... Just throw them at me ! -- Vincent Legoll