On Sat, Aug 13, 2016 at 06:15:59PM +0100, Marius Bakke wrote: > * gnu/packages/machine-learning.scm (dlib): New variable.
Thanks! > + (version "19.0") The released 19.1 yesterday. Will you send an updated patch using the latest version? > + (arguments > + `(#:phases > + (let ((test-dir (string-append "../dlib-" ,version > "/dlib/test/build"))) > + (modify-phases %standard-phases > + (add-before 'check 'build-test-suite > + ;; No test target, so we build and run the unit tests here. > + (lambda _ > + (mkdir-p test-dir) > + (chdir test-dir) > + (zero? (system* "cmake" "..")) > + (zero? (system* "cmake" "--build" "." "--config" "Release")))) > + (replace 'check > + (lambda _ (zero? (system* "./dtest" "--runall")))) I think we should combine these two phases, and use with-directory-excursion (defined in guix build utils) instead of chdir-ing back and forth. > + (add-after 'check 'ascend-to-build-directory > + (lambda _ (chdir "../../../../build") #t)))))) Then, this phase can be removed. What do you think?