David Craven <da...@craven.ch> writes: > * gnu/packages/gnome.scm (mobile-broadband-provider-info): New variable.
The summary line to should be "gnu: Add mobile-broadband-provider-info." without the "gnome: ". By our conventions, starting a summary line with "gnu: gnome: " indicates a change to the 'gnome' package, which is not the case here, and leads to confusion in practice. I read this summary line as meaning that 'mobile-broadband-provider-info' was added to gnome's propagated-inputs. This same issue applies to the other patches in this patch set as well. When adding new packages, our convention is simply to write "gnu: Add <package-name>." Thanks, Mark > --- > gnu/packages/gnome.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 4a0be01..7bc0445 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -21,6 +21,7 @@ > ;;; Copyright © 2016 Leo Famulari <l...@famulari.name> > ;;; Copyright © 2016 Alex Griffin <a...@ajgrf.com> > ;;; Copyright © 2016 ng0 <n...@we.make.ritual.n0.is> > +;;; Copyright © 2016 David Craven <da...@craven.ch> > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -4460,6 +4461,27 @@ devices, and provides VPN integration with a variety > of different VPN > services.") > (license license:gpl2+))) > > +(define-public mobile-broadband-provider-info > + (package > + (name "mobile-broadband-provider-info") > + (version "20151214") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnome/sources/" > + "mobile-broadband-provider-info/" version "/" > + "mobile-broadband-provider-info-" version ".tar.xz")) > + (sha256 > + (base32 > + "1905nab1h8p4hx0m1w0rn4mkg9209x680dcr4l77bngy21pmvr4a")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f)) ; No tests > + (home-page "https://wiki.gnome.org/Projects/NetworkManager") > + (synopsis "Datbase of broadband connection configuration") > + (description "Datbase of broadband connection configuration.") > + (license license:public-domain))) > + > (define-public network-manager-applet > (package > (name "network-manager-applet")