ng0 (2016-08-07 11:21 +0300) wrote:
[...]
> + (arguments
> + '(#:configure-flags
> + (list (string-append "--with-nssdir=" %output "/lib"))
> + #:parallel-tests? #f ; parallel building is not functional
> + #:tests? #f ; FAIL: test_testbed_logger_api
> + #:phases
> + ;; swap check and install phases and set paths to installed bin
> + (modify-phases %standard-phases
> + (add-after 'unpack 'patch-bin-sh
> + (lambda _
> + (and
> + (substitute* '("bootstrap")
I think there is no point to use list here as it is a single file.
> + (("contrib/pogen.sh") "sh contrib/pogen.sh"))
> + (for-each (lambda (f) (chmod f #o755))
> + (find-files "po" "")))))
'and' shouldn't be used in this phase as both 'substitute*' and
'for-each' do not specify the returned value, so:
(lambda _
(substitute* "bootstrap"
(("contrib/pogen.sh") "sh contrib/pogen.sh"))
(for-each (lambda (f) (chmod f #o755))
(find-files "po" ""))
#t)
I didn't build this package, I was just passing by and noticed those
small things. I hope someone else will review and commit this patch :-)
--
Alex
