Hi Danny! Danny Milosavljevic <dan...@scratchpost.org> skribis:
> On Wed, 31 Aug 2016 22:40:57 +0200 > l...@gnu.org (Ludovic Courtès) wrote: > >> > + (lambda* (#:key outputs make-flags #:allow-other-keys) >> > + (let ((configname (string-append ,board "_defconfig"))) >> >> Should be ‘config-name’ per our conventions, but ‘config’ is probably >> enough. >> >> > + (if (file-exists? (string-append "configs/" configname)) >> > + (zero? (apply system* "make" `(,@make-flags >> > ,configname))) >> > + (begin >> > + (display "Invalid boardname. Valid boardnames would >> > have been:") >> >> “board name” (two words). > >> > + (copy-file file-path target-file-path))) >> > + uboot-files))))))))) >> >> s/-path// > > For the record, a filename (or file path) is something completely different > from a file. It makes no sense to call a filename "file". Likewise, a > boardname is the name of a board. It's not the board. A configname is the > name of a config [file]. "config" would be the configuration itself. > > To develop this habit has taken a long time for me and it has paid off well. I guess it’s just a matter of convention, so no argument here. :-) GNU’s convention is to call “file name” the name of a file (not “filepath”, not “path”, not “filename”); in Scheme, that would give “file-name” as the variable name, which I often shorten to “file” because there are no files in Scheme, only I/O ports. Buy yeah, I’m nitpicking, or maybe even “bikeshedding”. :-) Ludo’.