Hi, some remarks:
+ (source (origin + (method url-fetch) + (uri (string-append + "https://launchpad.net/ubuntu/+archive/primary/+files/"; Is this the original source? I'd expact this to come from Google or AOSP? + name "_" version + ".orig.tar.xz")) Should be on the same line. + (patches (search-patches "android-tools-patches.patch" + "android-tools-makefiles.patch")) + (for-each (lambda (file) + (copy-file (string-append "core/" file "/" file) + (string-append bin file))) + '("adb" "adbd" + ;; "fastboot" + )))))))) Look like some are missing here? You are building four sub-packages install only two binaires? Maybe you want to use (find-files "bin" ".*") ? And maybe (install-file …) simplifies the code. + (synopsis "Android Tools") "Tools" is very generic. Please be more verbose here. Which kind of tools? What is their purpose? + (description + "Android Debug Bridge (adb) is a versatile tool lets you manage the state Please a short summary of included stuff/tools and maybe make the list into a @{itemize}. Regarding the patches: It looks like they add the vast parts of the Makefile, which is very curious. Why are they needed? (Please add as a comment to the package definition). -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |
