Alex Kost (2016-08-31 09:42 +0300) wrote: > John Darrington (2016-08-30 22:21 +0300) wrote: > >> * gnu/packages/astronomy.scm (wcslib): New variable. >> --- >> gnu/packages/astronomy.scm | 27 +++++++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> >> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm >> index 881e549..53e86c8 100644 >> --- a/gnu/packages/astronomy.scm >> +++ b/gnu/packages/astronomy.scm >> @@ -51,3 +51,30 @@ provides many advanced features for manipulating and >> filtering the information >> in FITS files.") >> (license (license:non-copyleft "file://License.txt" >> "See License.txt in the distribution.")))) >> + >> +(define-public wcslib >> + (package >> + (name "wcslib") >> + (version "5.15") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" name "-" >> version ".tar.bz2")) > > As for me, this line is too long, I would write: > > (uri (string-append > "ftp://ftp.atnf.csiro.au/pub/software/wcslib/" > name "-" version ".tar.bz2")) > >> + (sha256 >> + (base32 "1s2nig327g4bimd9xshlk11ww09a7mrjmsbpdcd8smsmn2kl1glb")))) >> + (inputs >> + `(("cfitsio" ,cfitsio))) >> + (build-system gnu-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + (add-before 'configure 'patch-/bin/sh >> + (lambda _ >> + (substitute* "makedefs.in" >> + (("/bin/sh") "sh"))))))) > > This phase should end with #t.
I've noticed that you didn't fix these things (long line and #t after substitute*). Could please do it next time :-) The same for 'cfitsio' package. -- Alex