Tobias Geerinckx-Rice <m...@tobias.gr> writes: > On 14/09/16 15:45, Marius Bakke wrote: >> It's not visible in the cgit interface, but it actually seems to >> support normal snapshot downloads: >> https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz > > I did not know that. Thanks for the tip! It still requires a snippet, > unfortunately.
Another thing, I think the snippet should be moved to a phase, as AFAIK origin snippets should be reserved for removing unwanted files, or for reproducibility. But, I may be wrong here. >>> + (home-page "http://mcelog.org/";) >> Nit-pick: the trailing slash is unnecessary :) > > Oh, I know, I just have a thing for proper root paths in URIs. > > I'm seeing someone about that. This made me chuckle. Perhaps I should see someone about saving that precious byte, too :) Also, is DESTDIR supposed to be /share, shouldn't it be $out/share? I think I'd define destdir as a variable, and use that also for the etcprefix instead of using a make variable. Thanks! Marius
