l...@gnu.org (Ludovic Courtès) writes: > Hello, > > Kei Kebreau <k...@openmailbox.org> skribis: > >> rennes <ren...@openmailbox.org> writes: >> >>> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote: >>>> >>>> This is a good patch! The only change I recommend is moving the >>>> defintion to gnome.scm. >>> >>> I update the patch, >>> * Create the definition in gnome.scm file. >>> * Move 'glib' to native-inputs. >>> * Delete Copyright duplicate for >>> ';;; Copyright © 2016 Rene Saavedra <ren...@openmailbox.org>' >>> >>> Thank you >> >> Looks good and works well. >> >> Does somebody want to commit this to master? >> I'd do it myself, but I'm unfamiliar with the process of commiting >> someone else's code and I don't want to break anything. > > It’s a good occasion to try—we need more reviewers! :-) > > The process is essentially to pipe the patch (which includes the commit > log and Subject: line) through “git am -s”. > > If that applies fine, just run ‘guix lint the-package’ and ideally ‘guix > build --rounds=2 the-package’ to catch any issues. > > If nothing comes up, just push! > > If minor issues (typos, synopsis, etc.) come up, you might commit them > on behalf of the author, or ask them what they prefer. > > Could you try and report back? :-) > > Thanks Kei & rennes! > > Ludo’.
I've already pushed it! I guess my last message only went back to Leo. Thank you and Leo for your help. :-) rennes, everything looked good. Thanks for your contribution!
signature.asc
Description: PGP signature
