On Tue, Oct 25, 2016 at 08:00:01PM +0300, Theodoros Foradis wrote: > * gnu/packages/engineering.scm (kicad): New variable.
Looks pretty good to me. Below are some things I would investigate and potentially fix on my own before pushing to Savannah; no need to send a new patch. Now we are just waiting to learn more about python2-wxpython... > +;; We use kicad from a git commit, because support for boost 1.61.0 > +;; has been recently added. > +(define-public kicad > + (let ((commit "4ee344e150bfaf3a6f3f7bf935fb96ae07c423fa") > + (revision "1")) > + (package > + (name "kicad") > + (version (string-append "4.0-" revision "." > + (string-take commit 7))) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.launchpad.net/kicad.git") Please use the correct URL here :) > + #:configure-flags > + (list "-DKICAD_STABLE_VERSION=ON" > + "-DKICAD_REPO_NAME=stable" > + "-DKICAD_BUILD_VERSION=4.0" If possible, we should use our package's version string here. We aren't really packaging KiCad 4.0, but rather 4.0 plus some extra Git commits, right? > + "-DCMAKE_BUILD_TYPE=Release" > + "-DKICAD_SKIP_BOOST=ON"; Use our system's boost library > + "-DKICAD_SCRIPTING=ON" > + "-DKICAD_SCRIPTING_MODULES=ON" > + "-DKICAD_SCRIPTING_WXPYTHON=ON" > + ;; Has to be set explicitely, as we don't have the wxPython > + ;; headers in the wxwidgets store item, but in wxPython. > + (string-append "-DCMAKE_CXX_FLAGS=-I" > + (assoc-ref %build-inputs "wxpython") > + "/include/wx-3.0") > + "-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE" > + "-DBUILD_GITHUB_PLUGIN=OFF") I would try building with this on. Does it require some unpackaged dependencies?