Hey! Marius Bakke <mba...@fastmail.com> skribis:
> Ludovic Courtès <l...@gnu.org> writes: > >> Marius Bakke <mba...@fastmail.com> skribis: >> >>> * gnu/build/file-systems.scm (check-file-system): Drop "-C" argument >>> from fsck for compatibility with other fscks. >> >> Oh so fsck.ext2 would no longer show any kind of progress report? >> That’s annoying. >> >> Could we address it differently? Not sure how, though. > > We would have to provide a custom check-file-system procedure for each > detected file-system. That might be needed in the long run anyway, but I > think this is a worthwhile compromise for now. What about adding a one-argument procedure as the ‘check-procedure’ field of <file-system>, with a sane default, like: (define (default-file-system-check file-system) #~(system* (string-append "fsck." #$(file-system-type file-system)) …)) ? In fact, that would also remove the need for the special case to add dosfstools to the initrd because we could simply write: (define (fat-file-system-check file-system) #~(system* #$(file-append vfatfsck/static "/bin/fsck.vfat") …)) and that would automatically bring vfatfsck/static to the initrd when it’s needed, and only then. WDYT? (Same design pattern as ‘open’ in <device-mapping>.) > I will push the okayed parts of this series tomorrow evening (with > fixes), unless there are further comments. Cool, thanks! Ludo’.