Marius Bakke <mba...@fastmail.com> writes: >>> > Failures in tests caused by external gd are not too serious to >>> > require us to switch to the bundled one I think. We may not even >>> > need to patch our libgd with php specific patches, since the >>> > failures are only slight deviation from the spec on corner cases. >>> > If you prefer that we apply these patches too, then we could, and I >>> > would still try to keep that up to date. >>> >>> OK. Let's use external gd for now barring any serious issues. >>> >>> > >>> > What I am more worried about are the iconv crashes. That may be due >>> > to lacking locales though. >>> >>> You could try commenting them out and adding "glibc-locales" to >>> native-inputs. Not sure if they will get picked up by that however. >>> >>> A better test may be to try out that particular functionality using >>> the installed version of php. If that works, we can be reasonably >>> sure that dropping the tests is fine. >>> >>> Attached is the final product, after adding a "gd-for-php" variable >>> with the two upstream patches, as well as sqlite-3.15.1 (separate >>> patch). >>> >>> I'll push this tomorrow if there are no further comments. Thanks for >>> your perseverance :) >> Just one question: why defining gd-for-php with define, and not >> define-public? > > It's to prevent it from showing up when people are searching for 'gd', > and also to prevent it from being included by other files. > > It's only a temporary measure until the next version is released, so I > saw no reason to export it. > > I'm on my way out, but will commit this tomorrow most likely :-)
Sorry for the delay, PHP is in master now!
signature.asc
Description: PGP signature
