On Sun, Nov 20, 2016 at 04:28:29PM +0100, Petter wrote: > From 595d438789c7c9a293ae7fac500ace7422073624 Mon Sep 17 00:00:00 2001 > From: Petter <pet...@mykolab.ch> > Date: Sun, 20 Nov 2016 13:39:13 +0100 > Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by > install-file <file> <dir>. > > * gnu/packages/bioinformatics.scm (bwa)[source]: Remove redundant mkdir-p. > * gnu/packages/bioinformatics.scm (eigensoft)[source]: Likewise. > * gnu/packages/bioinformatics.scm (snap-aligner)[source]: Likewise. > * gnu/packages/bioinformatics.scm (pardre)[source]: Likewise. > * gnu/packages/bioinformatics.scm (piranha)[source]: Likewise. > * gnu/packages/maths.scm (hypre)[source]: Likewise. > * gnu/packages/mp3.scm (mpc123)[source]: Likewise. > * gnu/packages/music.scm (tuxguitar)[source]: Likewise. > * gnu/packages/pdf.scm (impressive)[source]: Likewise. > * gnu/packages/qemu.scm (qemu)[source]: Likewise. > * gnu/packages/tls.scm (openssl)[source]: Likewise.
Thanks! A few requests... First, I think that most, if not all, of these changes are not in the [source] field of the changed package definitions. I bet that they are all in the [arguments] field. Can you send a revised patch with an updated commit message? Second, we can't change the OpenSSL package on the master branch, because many things depend on it: $ guix refresh -l openssl@1.0.2 Building the following 1090 packages would ensure 2981 dependent packages are rebuilt [...] We do non-security related changes to that sort of "core" package on the core-updates branch, which is merged into master every couple months. Otherwise, we'd be rebuilding everything constantly, and users would be unhappy. So, will you submit a separate patch for the OpenSSL change? Make sure it applies cleanly to the core-updates branch. You don't need to try building this; it will take forever, as you noticed.