ng0 <n...@libertad.pw> skribis: > Ludovic Courtès <l...@gnu.org> writes: > >> David Craven <da...@craven.ch> skribis: >> >>> * guix/build-system/cargo.scm (default-cargo, default-rustc, >>> %cargo-build-system-modules, cargo-build, lower, cargo-build-system): >>> New variables. >>> * guix/build/cargo-build-system.scm (configure, build, check, install, >>> %standard-phases, cargo-build): New variables. >> >> [...] >> >>> +(define* (install #:key inputs outputs #:allow-other-keys) >>> + "Install a given Cargo package." >>> + (let* ((out (assoc-ref outputs "out")) >>> + (src (assoc-ref inputs "source")) >>> + (bin (string-append out "/bin")) >>> + (rsrc (string-append out "/rustsrc"))) >>> + (mkdir-p rsrc) >>> + ;; Rust doesn't have a stable ABI yet. Because of this >>> + ;; Cargo doesn't have a search path for binaries yet. >>> + ;; Until this changes we are working around this by >>> + ;; distributing crates as source and replacing >>> + ;; references in Cargo.toml with store paths. >>> + (copy-recursively "src" (string-append rsrc "/src")) >> >> OK. In >> <https://lists.gnu.org/archive/html/guix-devel/2016-09/msg01991.html>, I >> suggested using ‘share/rust-source’ or similar to store the source. >> Would it be possible? >> >> Last thing: Could you add a couple of lines in guix.texi under “Build >> Systems”? >> >> OK with these changes. >> >> Thanks! >> >> Ludo’. >> >> > Hi, would it be possible to add some very short notes on why this > isn't complete from your (David) view?
Given the work that has gone into these Rust patches, I think it would be nice to apply them and possibly document any shortcoming or future work items. WDYT, David? :-) Ludo’.
