Marius Bakke <[email protected]> skribis: > Ludovic Courtès <[email protected]> writes: > >> Hello, >> >> To reconfigure my system on UEFI, I had to apply this patch: >> >> modified gnu/bootloader/grub.scm >> @@ -401,7 +401,8 @@ submenu \"GNU system, old configurations...\" {~%") >> ;; root partition. >> (setenv "GRUB_ENABLE_CRYPTODISK" "y") >> (unless (zero? (system* grub-install "--boot-directory" install-dir >> - "--efi-directory" efi-dir)) >> + ;; "--efi-directory" efi-dir >> + )) >> (error "failed to install GRUB (EFI)"))))) >> >> >> Before that ‘grub-install’ would fail because ‘efi-dir’ would actually >> be “/dev/sda”, which is what I have in the ‘device’ field of >> ‘grub-configuration’. >> >> Removing the “--efi-directory” solves the problem because ‘grub-install’ >> automatically determines that the EFI directory is mounted at /boot/efi. >> >> I think 2941b347b664a3d3114de0ac95e28db78db66144 is bogus because it >> assumes that the second argument of the gexp’d lambda is ‘efi-dir’, >> where in fact it is the ‘device’ field of the bootloader config. >> >> So what is the preferred fix? Simply remove “--efi-directory” like I >> did above, and rename ‘efi-dir’ to ‘device’ to avoid the ambiguity? >> Thoughts? > > Maybe we could rename "device" to something like "target" and update the > documentation to mention that "target" means the _mounted_ EFI System > Partition for grub-efi, but is typically a block device.
You mean it’s a block device except for EFI, right? So yes, we can rename ‘device’ to ‘target’, and we should at least document what you wrote. > "device" was a no-op for grub-efi anyway since it autodiscovered > "/boot/efi", at least now we can choose a different location. Right. Do you feel like updating the doc and examples? :-) Thanks, Ludo’.
