guix-comm...@gnu.org writes: > roptat pushed a commit to branch master > in repository guix. > > commit e8cfce439afed945e352ad28f73f0a5f7840f503 > Author: Julien Lepiller <jul...@lepiller.eu> > Date: Thu Mar 28 22:55:17 2019 +0100 > > gnu: php: Disable failing tests on armhf. > > * gnu/packages/php.scm (php)[arguments]: Disable failing tests on armhf. > --- > gnu/packages/php.scm | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm > index 8d96e54..ffb81da 100644 > --- a/gnu/packages/php.scm > +++ b/gnu/packages/php.scm > @@ -86,7 +86,7 @@ > #t)))) > (build-system gnu-build-system) > (arguments > - '(#:configure-flags > + `(#:configure-flags > (let-syntax ((with (syntax-rules () > ((_ option input) > (string-append option "=" > @@ -182,6 +182,17 @@ > (substitute* "ext/standard/tests/streams/bug60602.phpt" > (("'ls'") (string-append "'" (which "ls") "'"))) > > + ,@(if (string-prefix? "armhf" (or (%current-system) > + (%current-target-system))) > + ;; Drop tests known to fail on armhf. > + '((for-each delete-file > + (list > + "ext/calendar/tests/unixtojd_error1.phpt" > + ;; arm can be a lot slower, so a > time-related test fails > + "ext/fileinfo/tests/cve-2014-3538-nojit.phpt" > + "ext/pcre/tests/bug76514.phpt" > + "ext/pcre/tests/preg_match_error3.phpt")))) > + > ;; Drop tests that are known to fail. > (for-each delete-file > '("ext/posix/tests/posix_getgrgid.phpt" ; Requires > /etc/group.
Hey, I think I might be encountering an issue with this change. When running package-transitive-supported-systems on php, I get the following error. In procedure append: Wrong type argument in position 1 (expecting empty list): #<unspecified> My guess is that the #<unspecified> in the error is coming from the 2nd, unspecified branch of the if statement introduced here. I'm also not quite sure what the condition of the if will do, when will (%current-system) not be present? Thanks, Chris
signature.asc
Description: PGP signature