Hi Mark, Mark H Weaver <m...@netris.org> writes:
> Ricardo Wurmus <rek...@elephly.net> writes: > >> I think it’s very ugly that we still need to end phases with #T, even >> though build systems don’t care any more. The only thing that aborts a >> build phase now is an exception. > > I would be glad if this were the case, but I believe you're mistaken. > On both master and core-updates, in (guix build gnu-build-system), the > 'gnu-build' procedure iterates over the phases using 'every', and > procedure passed to 'every' ends by returning 'result', which is the > value that the phase returned. Am I missing something? No, you are correct. My meaning was more about intent; in the early days of the change to INVOKE I’ve seen a couple of warnings telling me that a phase returned #<unspecified> or #F, but that didn’t result in aborting the build. We have decided a long time ago that the only way to exit a build should be through an exception, so I think it’s time to update the last few build system remnants of the Boolean assumption (on core-updates). -- Ricardo
