On Thu, 28 Apr 2022 21:57:04 +0200 Maxime Devos <maximede...@telenet.be> wrote:
> Liliana Marie Prikler schreef op do 28-04-2022 om 19:27 [+0200]: > > > How does this help with double wrapping? Whether the wrappers / > > > originals are put in /bin or $RAWBIN_DIR, it's still wrapped > > > twice. > > Because $RAWBIN_DIR can be ignored when wrapping. This means that > > stuff that's already in it won't be added again. > > [...] > > Constructing the wrapper is not so much the problem, it's not > > wrapping the already wrapped binaries. > > Why can $RAWBIN_DIR be ignored when wrapping? If the build system > just sets $X during its wrappers, but the application needs $Y as well > (wrapped in a build phase), then if the extra wrapping is cancelled, > then the application won't get its $Y variable, which seems like a bug > to me. > > Greetings, > Maxime. It should be pretty easy to detect a wrapped binary without moving it. We could just include a magic string in it and scan for that, the exact same way we scan for store references. If it contains the "wrapped" magic UUID, it's wrapped.
