Hi,

Christopher Baines <[email protected]> skribis:

> Ludovic Courtès <[email protected]> writes:
>
>> Christopher Baines <[email protected]> skribis:
>>
>>> [email protected] writes:
>>>
>>>> civodul pushed a commit to branch master
>>>> in repository guix.
>>>>
>>>> commit e45306c1982aee194243cf661295c7ca776d879f
>>>> Author: Ludovic Courtès <[email protected]>
>>>> AuthorDate: Thu Apr 20 10:38:37 2023 +0200
>>>>
>>>>     services: postgresql: Add default package.

[...]

>> Oh, my bad.  I found it weird that the default value would be found in
>> the service and not in the configuration object.  The result is that
>> there is a default value, just not where you’d expect it.
>>
>> But yeah, I understand the rationale of the commit above, so we should
>> probably revert to that and add a comment explaining why there’s no
>> default.
>>
>> I wonder how we can make sure that users can still write (say):
>>
>>   (service cuirass-service-type)
>>
>> without having to explicitly specify which postgresql version they want
>> to use.
>>
>> WDYT?
>
> Yeah, we're just moving the problem of matching up the PostgreSQL
> software and data at the moment, but I think it's still preferable to
> make the problem clear in the configuration and when reconfiguring
> rather than delaying things to when the service doesn't start.

Yeah, OK.  So I guess we can revert
e45306c1982aee194243cf661295c7ca776d879f and add a comment explaining
the lack of a default value.  If that sounds good to you, please go
ahead or let me know if I should do it.

> It would be good to at least have some Guix specific documentation on
> how to migrate from one PostgreSQL version to another, and ideally this
> could be integrated in to the service somehow. That's the blocking issue
> to providing defaults here, we're just setting the user up for the
> service not starting at some point in the future when we change the
> default version of PostgreSQL.

I’m not really in a position to help but I agree!

Thanks,
Ludo’.

Reply via email to