Hi Suhail, On 5 Feb, Suhail wrote: > Felix Lechner via <help-g...@gnu.org> writes: > > > Another is that committers should commit what they think is right > > rather than ask for revised patches. > > I could be mistaken, but I believe this does happen today at least some > of the time. Is your position that > > 1. this never happens today and thus, should happen some times when > warranted. Or that, > > 2. it happens far too rarely today, and should happen more often. Or > that, > > 3. committers should never ask for revisions? (...)
Just to reply to this part, there were a variety of views on what the correct balance was between teaching someone and fixing issues so that a contributors patch was applied without them having to make further efforts. The general opinion seemed to be, that it was better to fix small issues and commit the change for new users, so they had the satisfaction of their contribution making it into the repository. One proposal was to do the 'fix', and to then reply back to the bug with a diff - showing what was done. Steve
