Hi, Vagrant Cascadian <[email protected]> writes:
> I pushed a fix for the recently added news entry, presumably due to a > rebase without updating the corresponding etc/news.scm entry with the > new commit: > > 46104698d4f7965f07d89debd196f6475860eccd news: Fix > home-dotfiles-configuration-excluded entry. > 0ab6bc4faefe8adb3f1695f77e062775f5df980d news: Add entry for fix in > home-dotfiles-configuration-excluded. > f013a062f636b0c8f4b30e7aca305c0621070cf7 gnu: home: dotfiles: Exclude > directories. > > In theory, check-channel-news should have caught this before pushing, > although it got me wondering if it is actually working correctly... > > Does check-channel-news check the branch being pushed for the commit, or > does it just check that the commit exists at all? > > If someone had the commit in a local branch, but not in the branch being > pushed, will check-channel-news catch the problem? A different question: I'm not sure why I'm listed in ‘Reviewed-by’. I commented on the pull request but didn't approve it or explicitly said to add my name. In fact I neither knew its exact implementation nor had actually tested it. What's the common practice on the trailers? My personal practice is to link to the original information and add names only when explicitly asked. Thanks
