Hi Dirk, On Jun 10, 10:16 am, Dirk Möbius <dmoeb...@gmx.net> wrote: > This is great! > We will most likely need this when we can no longer avoid updating to > a >128 release because of crucial bugfixes. I don't have the time to > evaluate your "patch" right now but I sure will do. You're > bookmarked. :-)
Please make sure you test it extensively, because I don't have influence on the conversion itself. If "script to" or "runscript from" fails, the migration of course fails, too. > > Without looking at your code, I guess you patched only a small couple > of lines in H2 core to detect whether the database format is old and > jump to your migration tool entry point. You are right, the only change is an additional call in org.h2.Driver.connect(url, info) to org.h2.upgrade.v1_1_to_v1_2.Migrate.convertToPageStoreIfNeeded(url, info) > Maybe the H2 core could be > changed so that this becomes an extension point where third party > libraries could add their logic? H2 could search for those extension > libraries using the standard Java service lookup mechanism (META-INF/ > services). That way H2 could remain unpatched, and the migration tool > could be distributed as a separate add-on. What do you think? Yes I thought about that, but I decided against, because I wanted to make an instant release for the h2 users. In the future, such "add ons" or "plugins" should be recognized on the fly by the default H2 version, so developers can ship the default distribution with the migration tool as a separate tool. > > Anyway, great work. Many thanks! > Dirk. Thank you Regards Christian Peter -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To post to this group, send email to h2-datab...@googlegroups.com. To unsubscribe from this group, send email to h2-database+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/h2-database?hl=en.
