Thanks, Noel - I'll take a shot. Am I ok to assume I can do this as a potentially breaking change or should I add another feature toggle on top of it all?
My gut feeling says the risk of breaking anything is low enough to take it, but if someone relies on data being trimmed and is using a mode that will not do it after the change, then it will break. Peter On Friday, May 20, 2016 at 6:24:53 PM UTC+10, Noel Grandin wrote: > > > > On 2016/05/19 5:39 AM, Peter Becker wrote: > > > > I looked at how I could possibly fix this. The relevant code seems to be > the first line > > in org.h2.value.ValueStringFixed#get(String). I could probably add > another field in org.h2.engine.SysProperties to > > toggle the behaviour (obviously defaulting to the current one), but in > many ways it seems appropriate to have it as a > > toggle on org.h2.engine.Mode. > > Putting a new flag in Mode is the right thing to do. > > Changing ValueStringFixed#get seems like overkill. There are only a couple > of call-sites that would need > space-preservation, and from those you should be able to get the Mode. > > Those call sites are org.h2.store.Data and org.h2.mvstore.db.ValueDataType > > You will probably need to extend the org.h2.store.DataHandler interface > to expose the Mode to the above classes. > > > Regards, Noel > -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to h2-database+unsubscr...@googlegroups.com. To post to this group, send email to h2-database@googlegroups.com. Visit this group at https://groups.google.com/group/h2-database. For more options, visit https://groups.google.com/d/optout.
