Hello! This feature is nice, but there are significant problems in your implementation.
1. I think it is a very bad idea to implement it on top of oldestVersionToKeep from MVStore. MVStore by itself creates a lot of garbage and this setting will effectively prevent garbage collection. In case of H2, all these versions also can be lost because H2 can rewrite the whole storage during shutdown. MVStore is actually a third storage engine for H2 and who knows, maybe there will be a new one without this setting or MVStore itself will be changed incompatibly. I think you need to find some other way. 2. Your implementation seems to be not compatible with anything, including Oracle. You shouldn't use mixed syntax partially taken from Oracle, partially your own, because it will prevent introduction of Oracle-specific features in Oracle compatibility mode due to syntax conflict. You also should use the same code style as the whole project. Please, don't use var and don't invent new interfaces for unit tests. I tried to add some reconnections to your tests and they started to fail. You need to test all these cases too. -- You received this message because you are subscribed to the Google Groups "H2 Database" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/h2-database/33b6bbc6-7779-4e37-86fd-36037aae5224n%40googlegroups.com.
