Inline... Nicholas Solter wrote: > Ed McKnight wrote: >> Prior version of this message had the links pointing to a different >> location than the text of the link. Sorry for any distress. Hope this >> one works correctly. --emk >> >> ---------------------------------------- >> Folks, >> >> This code review (two parts--see below) is primarily for data service >> wizard installation, part of the package migration from SVR4 to IPS, >> but also includes some other changes. >> >> Under SVR4, the wizards were registered with cacao in postinstall and >> unregistered in postremove. In order to avoid requiring a user action >> (such as running scinstall) to accomplish the registration under IPS >> I've implemented "register on first use" logic in clsetup. SVR4 >> packages delivered the reg (xml) files into individual data service >> namespaces under /opt, then registration (script >> /usr/cluster/lib/ds/serviceregister) copied the reg files into a reg >> directory where cacao would find them. My change is to deliver the >> reg files directly into the reg file directory and every time the >> data services menu is displayed we test for changes (files added or >> removed,) and rerun the registration if any changes are found. SVR4 >> packages are installed via JASIT installer and it's all agents >> installed or none. Under IPS users may install all services in one >> shot or any individual services can be installed and uninstalled at >> any time. Thus, the continual retesting. >> >> I also implement a fix for 6805577 "clsetup should not show >> unsupported data services on colorado cluster" by following the >> pattern scinstall uses for disabling selections. Thus, data services >> that are not installed will still show in the menu but will be >> disabled and cannot be selected. This provides the most automatic >> flexibility for adding data service support as Colorado's Phases >> proceed, and as users add or delete data services from their cluster, >> and is a recognized user interface pattern in our interactive cli's. >> >> http://cr.opensolaris.org/~emk/CO-IPS-ds1a/ is changes to the >> framework gate, with changes to clsetup, described above, as well as >> changing internal nomenclature and abbreviations from "meta-package" >> to "group-package." Another change to scinstall relocates the call to >> import all smf manifests up much higher in the execution path. >> >> http://cr.opensolaris.org/~emk/CO-IPS-ds2a/ is changes to the data >> service gate, including group and "loose package" signature files >> (these files support removing packages via 'scinstall -r'; the logic >> was reviewed with the first major scinstall changes for IPS.) Also, >> the data service wizard xml registration files are relocated as >> described above. >> >> > > Ed, > > Sorry for the late review. Just a couple comments: > > usr/src/cmd/clcommands/commands/clsetup/clsetup.ksh > > Is the check for HA-Oracle and Oracle RAC really the same?
Yup. Specifically got this info from those in the know. > > We may in the future make the logical hostname and other built-ins > optional too. I guess if we do that, we can make these options > optional at that point. Yup. Right now there's no separate package to test for. Made optional, there would be, so no need to invent more algorithms. thx, --emk > > Thanks, > Nick
