> Also, everyone: I think we should strive to avoid making whitespace > changes in the same commits as real changes. 3461 is a good example of > this. > > Other people have complained about this in the past. As Owen says > later, it's an editor setting. I use 3 or 4 different apps to edit > things, depending on what machine I'm on and how in-depth the change > is. Whitespace is the last of my concerns... Skim over it, it's not > worth making a huge deal out of - focus on something important > instead.
I'll focus on what I want, thanks. That's the luxury of using my own time to work on an open source project. I made a simple request that would make reading diffs much easier. If your editors introduce changes you didn't make, you should be using better tools. You should always be checking your own diffs before committing, in my opinion. The problem is in the "skim over it" part. For example, it's not immediately obvious what changed in r3461. If the whitespace was separated from the ACTUAL change, the one change (in 3 chunks) would be immediately visible. You might think it's not important, but I think clarity in diffs _is_ important for code review. If I'm the only one who thinks this way, I'm happy to shut up about it, but I suspect I'm not. S --~--~---------~--~----~------------~-------~--~----~ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev -~----------~----~----~----~------~----~------~--~---
