My plugin was just a quick knock up that I did in about 10 mins in a vein attempt to get compression working for most scenarios without spending too much time or effort on it. Not much thought went into it either.
I posted my code for you to take what you wanted from it and incorporate it into your plugin, so by all means, help yourself. You may want to also create a trunk compatible version of your plugin too. As you're licensing it under the Apache license, you can bung it into habari-extras and I'll be more than happy to create and test a trunk version for you. Cheers, Colin On Tue, Apr 6, 2010 at 6:43 PM, Da:Sourcerer <[email protected]> wrote: > Haha, oh wow. At least this proves the concept to be good :)) > > Well, my plugin ended up being a bit more complex than initially > thought. I just wanted > to work close to the RFCs (which includes proper content negotiation.) > The broad support of compression algorithms has its roots in a > "because it can be done" > attitude on my behalf. Most of the time (x-)gzip will be selected by > the plugin anyway. > I'm currently toying with the idea of letting the admin decide which > algorithms are available > via the plugin's config page. That way compression algorithms causing > problems (e.g. > lynx/elinks seems to have issues with this plugin. I cannot tell if > that's because lynx' > compress is broken or if I've done something wrong. I suspect later > one.) can be > switched of selectively while preserving general functionality. > > As for your code: You might want to consider using gzencode() instead > of manipulating > the output of gzcompress(). Also, I find your compression level a bit > high. IMHO anything > above 6 has little gain over a lot of additional CPU cycles. > > But I really like your idea for a threshold... Mind if I put that as > an option into the next > version of my plugin? > > Have fun, > Da:Sourcerer > > -- > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/habari-dev > > To unsubscribe, reply using "remove me" as the subject. > -- Colin Seymour Blog: http://colinseymour.co.uk Tech Stuff: http://www.lildude.co.uk Barefoot Running: http://barefootrunner.co.uk -- To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/habari-dev
