On Sun, May 22, 2016 at 10:29:21PM +0200, Markus Teich wrote:
> - Use simple XftColor type instead of Clr struct => No need for drw_clr_free
>   function.
> - Replace ClrScheme struct with simple array of XftColor items `Scm`.
> - Add Enum with ColFg and ColBg for indexing Scm type variables.
> - Remove border color, since drw.c does never use it. dwm can still use it by
>   creating a 3 element Scm.

I'm willing to apply your unification patches to dmenu and dwm, but can you
make a patch for dwm/dmenu if it breaks it?

>  
> -typedef struct {
> -     Clr *fg;
> -     Clr *bg;
> -     Clr *border;
> -} ClrScheme;
> +enum { ColFg, ColBg, ColCount }; /* Scm index */
> +typedef XftColor *Scm;
>  

I don't like the typedef to a pointer here.

Kind regards,
Hiltjo

Reply via email to