Hi Markus On Sat, Jan 07, 2017 at 05:21:28PM +0100, Markus Teich wrote: > - unify multi-line expression alignment style. > - unify multi-line function call alignment style. > - simplify client moving on monitor count decrease. > - clarify comment for focusin(). > - remove old confusing comment about input focus fix in focusmon(). The > explanation is already in the old commit message, so no need to keep it in > the > code. > - remove old comment describing even older state of the code in focus(). > - unify comment style. > - break up some long lines. > - fix some typos and grammar. > --- > > > Heyho, > > this patch contains some cleanup as Anselm anounced he plans to release a new > version of dwm soon. Feel free to discuss on specific hunks as there are a few > style unifications. > > --Markus > > > LICENSE | 2 +- > config.def.h | 2 +- > dwm.c | 64 > ++++++++++++++++++++++++++++-------------------------------- > 3 files changed, 32 insertions(+), 36 deletions(-) > > [...] > > for (m = mons; m && m->next; m = m->next); > - while (m->clients) { > + while ((c = m->clients)) { > dirty = 1; > - c = m->clients;
All changes are style and whitespace fixes except this one which I have already reviewed so this patch looks good to me. Cheers, Silvan > m->clients = c->next; > detachstack(c); > c->mon = mons; > @@ -1913,8 +1910,7 @@ updategeom(void) > free(unique); > } else > #endif /* XINERAMA */ > - /* default monitor setup */ > - { > + { /* default monitor setup */ > if (!mons) > mons = createmon(); > if (mons->mw != sw || mons->mh != sh) { > @@ -1988,7 +1984,7 @@ updatesizehints(Client *c) > } else > c->maxa = c->mina = 0.0; > c->isfixed = (c->maxw && c->minw && c->maxh && c->minh > - && c->maxw == c->minw && c->maxh == c->minh); > + && c->maxw == c->minw && c->maxh == c->minh); > } > > void > @@ -2082,8 +2078,8 @@ wintomon(Window w) > } > > /* There's no way to check accesses to destroyed windows, thus those cases > are > - * ignored (especially on UnmapNotify's). Other types of errors call Xlibs > - * default error handler, which may call exit. */ > + * ignored (especially on UnmapNotify's). Other types of errors call Xlibs > + * default error handler, which may call exit. */ > int > xerror(Display *dpy, XErrorEvent *ee) > { > @@ -2098,7 +2094,7 @@ xerror(Display *dpy, XErrorEvent *ee) > || (ee->request_code == X_CopyArea && ee->error_code == BadDrawable)) > return 0; > fprintf(stderr, "dwm: fatal error: request code=%d, error code=%d\n", > - ee->request_code, ee->error_code); > + ee->request_code, ee->error_code); > return xerrorxlib(dpy, ee); /* may call exit */ > } > > -- > 2.10.2 > >