> Hi quinq,
Hi,
> If we are bikeshedding keybindings maybe this would be a good time to
> ask about Ctrl-q, Ctrl-b, and Ctrl-u being default in tabbed? These
> all conflict with the default bindings in most shells.
I think this is discutable indeed, I have attached patches to change
those.
Basically I've remapped:
Close client: Ctrl q to Ctrl ‐
Focus urgent: Ctrl u to Ctrl /
Toggle urgent: Ctrl Shift u to Ctrl Shift /
I've also changed the tab manipulation keys to what seems more
accessible to me:
Navigate around with j and k, which are directly fingers in idle state.
Move tabs around with h and l.
I'd like some feedback regarding all those changes, if people feel
concerned please tell me about it!
If I don't get opinion against it, I'll push those.
> This was surprising to me, as I assumed most tabbed users at least use
> Ctrl-u in the shell. Leaving it default could be justified on the
> basis that it forces users to configure tabbed to their liking. But if
> that is our philosophy, this change doesn't seem justified.
To be honest I don't use a qwerty layout so the default keys are not
in the way, so I didn't realize it…
> I will defer to your experience, but I would at least like to hear the
> thinking behind this.
>
> Best,
> Caleb
>
>From f6560fb3ce7283564fcce2f245b3f0acd8cb5ad1 Mon Sep 17 00:00:00 2001
From: Quentin Rameau <quinq@fifth.space>
Date: Thu, 11 May 2017 00:07:46 +0200
Subject: [PATCH 1/3] Move around navigation keybindings
Actual navigation key should be but on directly accessible j/k keys.
Tab deplacement keys are moved to h/l.
---
config.def.h | 8 ++++----
tabbed.1 | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/config.def.h b/config.def.h
index 2d23049..b40a94c 100644
--- a/config.def.h
+++ b/config.def.h
@@ -39,10 +39,10 @@ static Key keys[] = {
{ MODKEY|ShiftMask, XK_Return, focusonce, { 0 } },
{ MODKEY|ShiftMask, XK_Return, spawn, { 0 } },
- { MODKEY|ShiftMask, XK_l, rotate, { .i = +1 } },
- { MODKEY|ShiftMask, XK_h, rotate, { .i = -1 } },
- { MODKEY|ShiftMask, XK_j, movetab, { .i = -1 } },
- { MODKEY|ShiftMask, XK_k, movetab, { .i = +1 } },
+ { MODKEY|ShiftMask, XK_j, rotate, { .i = +1 } },
+ { MODKEY|ShiftMask, XK_k, rotate, { .i = -1 } },
+ { MODKEY|ShiftMask, XK_h, movetab, { .i = -1 } },
+ { MODKEY|ShiftMask, XK_l, movetab, { .i = +1 } },
{ MODKEY, XK_Tab, rotate, { .i = 0 } },
{ MODKEY, XK_grave, spawn, SETPROP("_TABBED_SELECT_TAB") },
diff --git a/tabbed.1 b/tabbed.1
index f8d08cb..ac21fc7 100644
--- a/tabbed.1
+++ b/tabbed.1
@@ -113,16 +113,16 @@ prints version information to stderr, then exits.
.B Ctrl\-Shift\-Return
open new tab
.TP
-.B Ctrl\-Shift\-h
+.B Ctrl\-Shift\-k
previous tab
.TP
-.B Ctrl\-Shift\-l
+.B Ctrl\-Shift\-j
next tab
.TP
-.B Ctrl\-Shift\-j
+.B Ctrl\-Shift\-h
move selected tab one to the left
.TP
-.B Ctrl\-Shift\-k
+.B Ctrl\-Shift\-l
move selected tab one to the right
.TP
.B Ctrl\-Shift\-u
--
2.12.2
>From 71da5761a266a6cb7898981f3d70da381b40d936 Mon Sep 17 00:00:00 2001
From: Quentin Rameau <quinq@fifth.space>
Date: Thu, 11 May 2017 00:22:23 +0200
Subject: [PATCH 2/3] Move urgent keybindings from u to /
---
config.def.h | 4 ++--
tabbed.1 | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/config.def.h b/config.def.h
index b40a94c..4b9d177 100644
--- a/config.def.h
+++ b/config.def.h
@@ -59,8 +59,8 @@ static Key keys[] = {
{ MODKEY, XK_q, killclient, { 0 } },
- { MODKEY, XK_u, focusurgent, { 0 } },
- { MODKEY|ShiftMask, XK_u, toggle, { .v = (void*) &urgentswitch } },
+ { MODKEY, XK_slash, focusurgent, { 0 } },
+ { MODKEY|ShiftMask, XK_slash, toggle, { .v = (void*) &urgentswitch } },
{ 0, XK_F11, fullscreen, { 0 } },
};
diff --git a/tabbed.1 b/tabbed.1
index ac21fc7..8267f67 100644
--- a/tabbed.1
+++ b/tabbed.1
@@ -125,7 +125,7 @@ move selected tab one to the left
.B Ctrl\-Shift\-l
move selected tab one to the right
.TP
-.B Ctrl\-Shift\-u
+.B Ctrl\-Shift\-/
toggle autofocus of urgent tabs
.TP
.B Ctrl\-Tab
@@ -134,7 +134,7 @@ toggle between the selected and last selected tab
.B Ctrl\-q
close tab
.TP
-.B Ctrl\-u
+.B Ctrl\-/
focus next urgent tab
.TP
.B Ctrl\-[0..9]
--
2.12.2
>From 613ebe6ee947ca7dbfc57781bbebfead09a22df8 Mon Sep 17 00:00:00 2001
From: Quentin Rameau <quinq@fifth.space>
Date: Thu, 11 May 2017 00:38:11 +0200
Subject: [PATCH 3/3] Move kill window keybinding from q to -
---
config.def.h | 2 +-
tabbed.1 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/config.def.h b/config.def.h
index 4b9d177..55cf5fd 100644
--- a/config.def.h
+++ b/config.def.h
@@ -57,7 +57,7 @@ static Key keys[] = {
{ MODKEY, XK_9, move, { .i = 8 } },
{ MODKEY, XK_0, move, { .i = 9 } },
- { MODKEY, XK_q, killclient, { 0 } },
+ { MODKEY, XK_minus, killclient, { 0 } },
{ MODKEY, XK_slash, focusurgent, { 0 } },
{ MODKEY|ShiftMask, XK_slash, toggle, { .v = (void*) &urgentswitch } },
diff --git a/tabbed.1 b/tabbed.1
index 8267f67..1245269 100644
--- a/tabbed.1
+++ b/tabbed.1
@@ -131,7 +131,7 @@ toggle autofocus of urgent tabs
.B Ctrl\-Tab
toggle between the selected and last selected tab
.TP
-.B Ctrl\-q
+.B Ctrl\--
close tab
.TP
.B Ctrl\-/
--
2.12.2
