On Thu, May 06, 2021 at 04:33:35PM +0200, Markus F.X.J. Oberhumer wrote:
> Hi Laslo,
> 
> On 2021-05-06 16:19, Laslo Hunhold wrote:
> > On Thu, 6 May 2021 16:11:33 +0200
> > "Markus F.X.J. Oberhumer" <mar...@oberhumer.com> wrote:
> > 
> > Dear Markus,
> > 
> >> this is my first post to this list, so I hope I got the email patch
> >> right.
> >>
> >> GitHub repo is at
> >> https://github.com/markus-oberhumer/suckless-st/compare/mild-const-correctness-improvements
> > 
> > thanks for your input, but please save the patch as a file (using git
> > diff or git format-patch) and attach it to your E-Mail. A GitHub-link
> > is not good because it doesn't satisfy archivability and is overkill,
> > among other things.
> 
> well, my email *did* have the patch attached - the github link was
> just for reference.
> 
> See https://lists.suckless.org/hackers/2105/17868.html
> 
> Cheers,
> Markus
> 
> > 
> > With best regards
> > 
> > Laslo
> > 
> 
> -- 
> Markus Oberhumer, <mar...@oberhumer.com>, http://www.oberhumer.com/
> 

Hi,

The patch looks fine. I'm not in favor of some of the const changes, but I think
it makes sense to make function parameters like for xstrdup() const.

I'll review and push it later.

Thanks,

-- 
Kind regards,
Hiltjo

Reply via email to