On Tue, Jul 13, 2021 at 08:04:19PM +0200, Hiltjo Posthuma wrote:
> On Mon, Jul 12, 2021 at 11:44:16PM +0200, Quentin Rameau wrote:
> > Some people are annoyed to have this new behaviour forced for some
> > application which use fake fullscreen.
> > ---
> > config.def.h | 1 +
> > dwm.c | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/config.def.h b/config.def.h
> > index 1c0b587..a2ac963 100644
> > --- a/config.def.h
> > +++ b/config.def.h
> > @@ -35,6 +35,7 @@ static const Rule rules[] = {
> > static const float mfact = 0.55; /* factor of master area size
> > [0.05..0.95] */
> > static const int nmaster = 1; /* number of clients in master area */
> > static const int resizehints = 1; /* 1 means respect size hints in
> > tiled resizals */
> > +static const int lockfullscreen = 1; /* 1 will force focus on the
> > fullscreen window */
> >
> > static const Layout layouts[] = {
> > /* symbol arrange function */
> > diff --git a/dwm.c b/dwm.c
> > index b0b3466..5b41d4c 100644
> > --- a/dwm.c
> > +++ b/dwm.c
> > @@ -835,7 +835,7 @@ focusstack(const Arg *arg)
> > {
> > Client *c = NULL, *i;
> >
> > - if (!selmon->sel || selmon->sel->isfullscreen)
> > + if (!selmon->sel || selmon->sel->isfullscreen && lockfullscreen)
> > return;
> > if (arg->i > 0) {
> > for (c = selmon->sel->next; c && !ISVISIBLE(c); c = c->next);
> > --
> > 2.32.0
> >
> >
>
> For the archives: this was discussed on IRC (so not ignored or anything).
>
> If there are more people having issues with the behaviour introduced in commit
> 67d76bdc68102df976177de351f65329d8683064 then I'll gladly hear it.
>
> https://git.suckless.org/dwm/commit/67d76bdc68102df976177de351f65329d8683064.html
>
> Small note, I prefer the style with (unneeded) braces:
>
> > + if (!selmon->sel || (selmon->sel->isfullscreen && lockfullscreen))
>
> Thanks,
>
Thanks all for the feedback. I've pushed Quentin his patch with the small
code-style change above.
--
Kind regards,
Hiltjo
