Hi,

On Thu Sep 15, 2022 at 3:45 PM CEST, NRK wrote:
> On Thu, Sep 15, 2022 at 01:31:02PM +0000, Tom Schwindl wrote:
> > -## BadLength X error in Xft when trying to render emoji
> > -
> > -Xft makes st crash when rendering color emojis with the following error:
> > -
> > -"X Error of failed request:  BadLength (poly request too large or internal 
> > Xlib length error)"
> > -  Major opcode of failed request:  139 (RENDER)
> > -  Minor opcode of failed request:  20 (RenderAddGlyphs)
> > -  Serial number of failed request: 1595
> > -  Current serial number in output stream:  1818"
> > -
> > -This is a known bug in Xft (not st) which happens on some platforms and
> > -combination of particular fonts and fontconfig settings.
> > -
> > -See also:
> > -https://gitlab.freedesktop.org/xorg/lib/libxft/issues/6
> > -https://bugs.freedesktop.org/show_bug.cgi?id=107534
> > -https://bugzilla.redhat.com/show_bug.cgi?id=1498269
>
> I don't think removing the entire section is the right idea, since there
> are distros which are still on older versions.
>
> > -The solution is to remove color emoji fonts or disable this in the 
> > fontconfig
> > -XML configuration.  As an ugly workaround (which may work only on newer
> > -fontconfig versions (FC_COLOR)), the following code can be used to mask 
> > color
> > -fonts:
>
> Simply changing this paragraph to say that the solution is to upgrade
> libXft should be the proper way to go IMO.
>
> - NRK

Thanks for the suggestion. I attached another patch which does this.
I also removed the last sentence, given that it's fixed now.

--
Best Regards,
Tom Schwindl
From 619604a617c8146044f68a2280f0792e2a78830f Mon Sep 17 00:00:00 2001
From: Tom Schwindl <schwi...@posteo.de>
Date: Thu, 15 Sep 2022 16:08:43 +0200
Subject: [PATCH] FAQ: libXft now supports BGRA glyphs

https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS
---
 FAQ | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/FAQ b/FAQ
index 969b195ebcff..b84abfec3ee2 100644
--- a/FAQ
+++ b/FAQ
@@ -239,12 +239,8 @@ https://gitlab.freedesktop.org/xorg/lib/libxft/issues/6
 https://bugs.freedesktop.org/show_bug.cgi?id=107534
 https://bugzilla.redhat.com/show_bug.cgi?id=1498269
 
-The solution is to remove color emoji fonts or disable this in the fontconfig
-XML configuration.  As an ugly workaround (which may work only on newer
-fontconfig versions (FC_COLOR)), the following code can be used to mask color
-fonts:
+This was fixed in libXft-2.3.5 [1]. To get the correct behavior, you need to
+upgrade to this or a newer version.
 
-	FcPatternAddBool(fcpattern, FC_COLOR, FcFalse);
+[1] https://gitlab.freedesktop.org/xorg/lib/libxft/-/blob/libXft-2.3.5/NEWS
 
-Please don't bother reporting this bug to st, but notify the upstream Xft
-developers about fixing this bug.
-- 
2.37.3

Reply via email to