Re: [hackers] [st][PATCH] Add support for DSR response "OK" escape sequence

[Santtu Lakkala]

On 6.2.2023 1.39, Adam Price wrote:

                tsetattr(csiescseq.arg, csiescseq.narg);
                break;
-       case 'n': /* DSR – Device Status Report (cursor position) */
-               if (csiescseq.arg[0] == 6) {
+       case 'n': /* DSR – Device Status Report */
+               switch (csiescseq.arg[0]) {
+               case 5: /* Status Report "OK" `0n` */
+                       ttywrite("\033[0n", sizeof("\033[0n"), 0);

This will write a NUL byte to the tty, which doesn't seem intentional.

+                       break;
+               case 6: /* Report Cursor Position (CPR) `<row>;<column>R` */
                        len = snprintf(buf, sizeof(buf), "\033[%i;%iR",
                                        term.c.y+1, term.c.x+1);

--
Santtu