[ 
http://issues.apache.org/jira/browse/HADOOP-327?page=comments#action_12420335 ] 

David Bowen commented on HADOOP-327:
------------------------------------


I think it is better to be as explicit as possible about which (checked) 
Exceptions your main() routine is not handling.  It is useful to the reader to 
know that the only checked exception that can be thrown is an IOException.  
This doesn't require any additional code, and in any case readability is more 
important than saving a line or two.



> ToolBase calls System.exit
> --------------------------
>
>          Key: HADOOP-327
>          URL: http://issues.apache.org/jira/browse/HADOOP-327
>      Project: Hadoop
>         Type: Bug

>   Components: util
>     Versions: 0.4.0
>     Reporter: Owen O'Malley
>     Assignee: Hairong Kuang
>      Fix For: 0.5.0
>  Attachments: exit.patch
>
> The new ToolBase class calls System.exit when the main routine finishes. That 
> will break if the application uses threads that need to finish before the jvm 
> exits. The normal semantics is that the program doesn't finish execution 
> until all of the non-daemon threads exit (including the main one) and 
> System.exit should never be called except for critical errors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to