[ http://issues.apache.org/jira/browse/HADOOP-396?page=comments#action_12424485 ] Devaraj Das commented on HADOOP-396: ------------------------------------
I think you missed removing the lines that stores the infoPort after DatanodeDescriptor is created in gotHeartBeat and registerDatanode from FSNameSystem.java. With your current patch we don't need to explicitly store the infoPort anymore. > Writable DatanodeID > ------------------- > > Key: HADOOP-396 > URL: http://issues.apache.org/jira/browse/HADOOP-396 > Project: Hadoop > Issue Type: Improvement > Components: dfs > Affects Versions: 0.4.0 > Reporter: Konstantin Shvachko > Assigned To: Konstantin Shvachko > Fix For: 0.5.0 > > Attachments: DatanodeID.patch, DatanodeID2.patch > > > This patch implements Owen's comments to HADOOP-321. Namely, > - Namenode.sendHeartbeat does not create a throwaway DatanodeDescriptor. > DatanodeID is sufficient in this case. > - DatanodeID is made Writable, and it also implements equals() and hashCode(). > - DatanodeInfo is updated to call base class methods in its implementation of > Writable interface. > - I changed the way strings are written/read using UTF8.writeString and > UTF8.readString. > - Some comments are updated. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
