[ 
http://issues.apache.org/jira/browse/HADOOP-517?page=comments#action_12433465 ] 
            
Michel Tourn commented on HADOOP-517:
-------------------------------------

A PushbackInputStream seems overkill for what we are talking about. And 
performance is critical here.

There is a standard efficient code pattern that will consume:
'\r'
or 
'\n'
or 
\r\n

(for Mac, Unix, Windows respectively)


> readLine function of UTF8ByteArrayUtils does not handle end of line correctly
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-517
>                 URL: http://issues.apache.org/jira/browse/HADOOP-517
>             Project: Hadoop
>          Issue Type: Bug
>         Environment: windows
>            Reporter: Hairong Kuang
>         Assigned To: Hairong Kuang
>         Attachments: eol.patch
>
>
> The readLine function does not read ahead looking for '\n' after it reads 
> '\r'. Therefore it incorrectly generates two lines, wth the second one empty 
> in the window platform.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to