[ http://issues.apache.org/jira/browse/HADOOP-601?page=comments#action_12442658 ] Doug Cutting commented on HADOOP-601: -------------------------------------
This looks good to me. +1 For comparison, the proxy approach might look something like: XxxProtocol proxy = new RetryProxy(XxxProtocol.class, Try.FOREVER); The weakness of this approach would be (a) the client would need to know how to build an appropriate proxy for the protocol, and (b) specifying different reliability contracts for different methods would be awkward. By contrast, your annotation-based approach keeps the reliability requirements with the protocol and per-method. > we need some rpc retry framework > -------------------------------- > > Key: HADOOP-601 > URL: http://issues.apache.org/jira/browse/HADOOP-601 > Project: Hadoop > Issue Type: Improvement > Components: ipc > Reporter: Owen O'Malley > Assigned To: Owen O'Malley > Fix For: 0.8.0 > > > We need some mechanism for RPC calls that get exceptions to automatically > retry the call under certain circumstances. In particular, we often end up > with calls to rpcs being wrapped with retry loops for timeouts. We should be > able to make a retrying proxy that will call the rpc and retry in some > circumstances. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
